<html>
<head><meta charset="utf-8"><title>local mini crater brainstorming · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html">local mini crater brainstorming</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="219986357"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/219986357" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#219986357">(Dec 15 2020 at 14:30)</a>:</h4>
<p>related to <a href="https://github.com/rust-lang/rust-clippy/issues/6429#issuecomment-741153345">https://github.com/rust-lang/rust-clippy/issues/6429#issuecomment-741153345</a></p>
<p>So, I might try adding a kind of "mini crater" to <code>clippy cargo dev</code> as a xmas project.</p>
<p>The idea is to:<br>
Download a fixed set of crates with fixed versions<br>
   We might need <code>reqwest</code> for that. Since this pulls in quite an amount of dependencies, I consider putting the minicrater behind a feature flag so that <code>cargo dev fmt</code> does not initially compile for 5 minutes just for formatting.<br>
   The crate versions need to be fixed to avoid new diagnostics from showing up unexpectedly. We can bump them manually when upstream code has changed a lot or we want to lint for new rustc syntax that does not exist in older crate versions.<br>
    We can probably use clippy preexisting <code>target</code> dir for storing the crates.</p>
<p>Run clippy on the crates<br>
    This will use the locally built clippy inside the repo, might need some hackery to find sysroot etc (same as the current compiletest impl)<br>
    Do we need a switch for <code>--release</code> and <code>--debug </code>clippy build?</p>
<p>Grab the lint output of clippy<br>
    We can use <code>cargo clippy --message-format short -- &lt;enable all the lints&gt;</code><br>
    Can we dump the result into a a file and save it in-repo?<br>
    CI could run the minicrater and throw an error if the logs are not up to date<br>
        (to make sure contributors of new lints have looked at changes)</p>
<p>Finally, checking where a lint triggered in our set of crates would just be a matter of running <code>git diff</code> and checking the logs</p>



<a name="219987327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/219987327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#219987327">(Dec 15 2020 at 14:36)</a>:</h4>
<p>FYI if you're just making blocking GET requests I highly recommend ureq, it's reliable, easy to use, and has very few dependencies. It's missing some features from reqwest but it sounds like you don't need a ton of features</p>



<a name="219987343"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/219987343" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#219987343">(Dec 15 2020 at 14:36)</a>:</h4>
<p>&lt;/soapbox&gt;</p>



<a name="219987629"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/219987629" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#219987629">(Dec 15 2020 at 14:38)</a>:</h4>
<p>thanks, will have a look. :)<br>
Back then when I googled something like "rust download library " request was probably the first lib that showed up <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="219987721"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/219987721" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#219987721">(Dec 15 2020 at 14:39)</a>:</h4>
<p>could also always check the local $CARGO_HOME first and copy crate sources from there, but that may be a bit over-engineered</p>



<a name="220094288"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220094288" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220094288">(Dec 16 2020 at 09:37)</a>:</h4>
<p>I could also go all-out and use <code>rustwide</code> for proper sandboxing (I already have a toy project which uses rustwide and runs clippy on all the local crates in the $CARGO_HOME and checks for panics) but that would add even more deps.</p>
<p>It may also download a few gigs of container images at first startup which is a bit slow</p>



<a name="220094320"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220094320" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220094320">(Dec 16 2020 at 09:37)</a>:</h4>
<p>(rustwide is what crater uses for sandboxing afaik)</p>



<a name="220094411"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220094411" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220094411">(Dec 16 2020 at 09:38)</a>:</h4>
<p>but since we have a controlled set of crates, that may not be needed</p>



<a name="220094988"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220094988" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220094988">(Dec 16 2020 at 09:45)</a>:</h4>
<p>Wasn't there also discussion on having this feature integrated in crater?</p>



<a name="220095620"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220095620" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220095620">(Dec 16 2020 at 09:52)</a>:</h4>
<p>Yeah, there was something about running clippy on crater. :)<br>
But I think running clippy on the entire rust ecosystem for finding FPs is a bit overkill (also it takes several days)</p>



<a name="220095781"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220095781" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220095781">(Dec 16 2020 at 09:54)</a>:</h4>
<p>I agree <span aria-label="grinning face with smiling eyes" class="emoji emoji-1f601" role="img" title="grinning face with smiling eyes">:grinning_face_with_smiling_eyes:</span>  But it looks like crater has a way to limit the number of crates it runs on? <a href="https://github.com/rust-lang/crater/blob/master/docs/bot-usage.md#creating-experiments">https://github.com/rust-lang/crater/blob/master/docs/bot-usage.md#creating-experiments</a></p>



<a name="220095930"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220095930" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220095930">(Dec 16 2020 at 09:55)</a>:</h4>
<p>(<code>crates: the selection of crates to use (default: full)</code>)</p>



<a name="220096245"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220096245" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220096245">(Dec 16 2020 at 09:58)</a>:</h4>
<p>hmm. afaik the common usecase is "recheck all crates that failed to build recently" but we might also be able to specify some crates manually...</p>



<a name="220096260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220096260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eduardo Broto <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220096260">(Dec 16 2020 at 09:58)</a>:</h4>
<p>We already have a small selection in the CI, but IMO this would be useful with a wider range of crates (not sure about how many though <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span>), and I think it would be unfeasible to run that in our CI, this is why crater was suggested. The infrastructure is already there, so why not take advantage of that?</p>
<p>We would need to automate checking the results in some way though, otherwise analyzing them could take too long xD</p>



<a name="220096425"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220096425" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220096425">(Dec 16 2020 at 10:00)</a>:</h4>
<blockquote>
<p>We already have a small selection in the CI</p>
</blockquote>
<p>This is only about ICEs I think? (we don't care about new warnings there, do we?)</p>



<a name="220096489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220096489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220096489">(Dec 16 2020 at 10:01)</a>:</h4>
<blockquote>
<p>This is only about ICEs I think?</p>
</blockquote>
<p>yep</p>



<a name="220096506"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220096506" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eduardo Broto <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220096506">(Dec 16 2020 at 10:01)</a>:</h4>
<p>Indeed, forgot about that</p>



<a name="220096548"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220096548" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220096548">(Dec 16 2020 at 10:01)</a>:</h4>
<p>Also I never run crater locally.<br>
IMO it would be nice if contributors could check for lint-results even before submitting a pr</p>



<a name="220096622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220096622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220096622">(Dec 16 2020 at 10:02)</a>:</h4>
<p>I agree that a short feedback loop would also be nice for this, instead of having to wait for someone to start a crater run and wait for the results</p>



<a name="220096742"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220096742" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eduardo Broto <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220096742">(Dec 16 2020 at 10:03)</a>:</h4>
<p>Yep the crater run would be if we have a longer stabilization process. I'm just hesitating about it being really useful having to do a trade-off between number of crates and expected resources, but we can try it, of course <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="220096744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220096744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220096744">(Dec 16 2020 at 10:03)</a>:</h4>
<p>does crater look at warnings at all...?</p>



<a name="220096835"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220096835" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eduardo Broto <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220096835">(Dec 16 2020 at 10:04)</a>:</h4>
<p>I don't know, it would probably need tweaking for this use case</p>



<a name="220096918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220096918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220096918">(Dec 16 2020 at 10:05)</a>:</h4>
<p>I don't think it does :/<br>
<a href="https://crater-reports.s3.amazonaws.com/pr-79135/index.html">https://crater-reports.s3.amazonaws.com/pr-79135/index.html</a><br>
seems to only check for exit status mostly</p>



<a name="220097260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220097260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220097260">(Dec 16 2020 at 10:08)</a>:</h4>
<p>we could start with the crates that rustc checks as part of <code>cargotest</code> <a href="https://github.com/rust-lang/rust/blob/master/src/tools/cargotest/main.rs#L14">https://github.com/rust-lang/rust/blob/master/src/tools/cargotest/main.rs#L14</a><br>
maybe also add cargo and a few proc macro crates (serde?),  rayon, and perhaps the top 10 downloads from crates io</p>



<a name="220098921"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220098921" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220098921">(Dec 16 2020 at 10:26)</a>:</h4>
<p>Maybe also some FFI heavy crate (although I wouldn't know which)</p>



<a name="220098936"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220098936" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220098936">(Dec 16 2020 at 10:26)</a>:</h4>
<p>apart from that the selection seems good to me</p>



<a name="220118234"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220118234" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220118234">(Dec 16 2020 at 14:01)</a>:</h4>
<blockquote>
<p>It may also download a few gigs of container images at first startup which is a bit slow</p>
</blockquote>
<p>you can set a custom docker image so it doesn't get all 7 GB of crates-build-env</p>



<a name="220155378"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220155378" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220155378">(Dec 16 2020 at 18:42)</a>:</h4>
<p>Having this would be great! Because we can't run this in our CI, I would suggest,  that we run this with every Rust / Clippy release _$somewhere_.  Then we can implement a process for new lints: New lints get added to nightly and if they pass the mini-crater run they get pushed to beta in the next release. </p>
<p>But I'm getting ahead of  myself. <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="220162566"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220162566" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220162566">(Dec 16 2020 at 19:39)</a>:</h4>
<p>do you mean a full clippy crater run or clippy on a set of crates?</p>



<a name="220189440"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220189440" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220189440">(Dec 16 2020 at 23:42)</a>:</h4>
<p>Oh I meant using the tool you want to write. I don't think we can run it on every CI run. But we can use it to determine which lint should be shipped to stable (for example).</p>
<p>I think the set of <code>cargotest</code> crates and some selected other crates, as you suggested, makes sense.</p>



<a name="220425996"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220425996" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220425996">(Dec 18 2020 at 20:45)</a>:</h4>
<p>think I got a MVP now :)</p>



<a name="220426656"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220426656" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220426656">(Dec 18 2020 at 20:52)</a>:</h4>
<p>the lint warnings that I get do not look very diverse though  :/</p>



<a name="220426716"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220426716" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220426716">(Dec 18 2020 at 20:52)</a>:</h4>
<p>it's not that bad, but there is still quite some room for improvement I</p>



<a name="220426787"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220426787" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220426787">(Dec 18 2020 at 20:53)</a>:</h4>
<p>I've also enabled <code>pedantic</code> and <code>cargo</code> lint groups</p>



<a name="220427627"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220427627" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220427627">(Dec 18 2020 at 21:01)</a>:</h4>
<p>some file inside <code>tokei</code> triggers  the identical-match arm lint  a few thousand times, urgh...</p>



<a name="220427645"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220427645" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220427645">(Dec 18 2020 at 21:01)</a>:</h4>
<p>I'm gonna ignore that crate for now</p>



<a name="220430219"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220430219" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220430219">(Dec 18 2020 at 21:28)</a>:</h4>
<p>Takes around 5 minutes to check all the crates currently, I think that doesn't hurt too much</p>



<a name="220431123"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220431123" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220431123">(Dec 18 2020 at 21:39)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust-clippy/pull/6469">https://github.com/rust-lang/rust-clippy/pull/6469</a></p>



<a name="220441226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220441226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220441226">(Dec 18 2020 at 23:46)</a>:</h4>
<p>Hmm, it would be really helpful if clippy showed the lint name in the one-line lint message :/</p>



<a name="220453533"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/local%20mini%20crater%20brainstorming/near/220453533" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Michael Wright <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/local.20mini.20crater.20brainstorming.html#220453533">(Dec 19 2020 at 04:40)</a>:</h4>
<p>I think it'll be easy to get if you used the json output format.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>